Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#4721] Update docs concerning prefill and Objects API #4722

Merged
merged 1 commit into from
Oct 8, 2024
Merged

[#4721] Update docs concerning prefill and Objects API #4722

merged 1 commit into from
Oct 8, 2024

Conversation

vaszig
Copy link
Contributor

@vaszig vaszig commented Oct 2, 2024 •
edited by sergei-maertens
Loading

Closes #4721
Closes #4723

Changes

  • Added note to the prefill docs for update_existing_object functionality in the Objects API
  • Updated the screenshots in the Objects API manual according to the improvements. This also needs update concerning the dutch text

Checklist

Check off the items that are completed or not relevant.

  • Impact on features

    • Checked copying a form
    • Checked import/export of a form
    • Config checks in the configuration overview admin page
    • Problem detection in the admin email digest is handled

  • Release management

    • I have labelled the PR as "needs-backport" accordingly

  • I have updated the translations assets (you do NOT need to provide translations)

    • Ran ./bin/makemessages_js.sh
    • Ran ./bin/compilemessages_js.sh

  • Commit hygiene

    • Commit messages refer to the relevant Github issue
    • Commit messages explain the "why" of change, not the how

@vaszig
[#4721] Update docs concerning Objects API
9a79c81 
- Added note to the prefill docs for update_existing_object
  functionality in the Objects API
- Updated the screenshots in the Objects API manual according to the
  improvements. This also needs update concerning the dutch text
@vaszig vaszig mentioned this pull request Oct 2, 2024
Closed
@vaszig
Copy link
Contributor Author

vaszig commented Oct 2, 2024

This handles part of the issue #4723 that has to do with the dutch texts update.

@codecov Codecov
Copy link

codecov bot commented Oct 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.56%. Comparing base (1a67d2a) to head (9a79c81).
Report is 736 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #4722   +/-   ##
=======================================
  Coverage   96.56%   96.56%           
=======================================
  Files         746      746           
  Lines       25174    25174           
  Branches     3310     3310           
=======================================
  Hits        24309    24309           
  Misses        601      601           
  Partials      264      264

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sergei-maertens
sergei-maertens approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@sergei-maertens sergei-maertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked the Dutch text after screenshot updates, no changes are needed!

@sergei-maertens sergei-maertens merged commit e25afd6 into master Oct 8, 2024
33 checks passed
@sergei-maertens sergei-maertens deleted the task/4721-document-objects-api-update-existing-object branch October 8, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergei-maertens sergei-maertens sergei-maertens approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Objects API manual (Dutch docs) Make sure prefill object is updated when the owner changes values
2 participants
@vaszig @sergei-maertens